Fix V8 function in Value.h#186
Open
Zosoled wants to merge 1098 commits into
Open
Conversation
fah-client now utilizes the sd-device API. Requires systemd 240 or later.
…-device Enable systemd support only with sd-device present
This reverts commit dcd7e5d. sd-device usage in fah-client was dropped.
…d-device Revert "Enable systemd support only with sd-device present"
The /usr/lib/rpm/brp-suse.d/brp-15-strip-debug build root policy script on openSUSE (from the brp-check-suse package) does not honor the __strip definition. To ensure debug symbols are preserved, set the environment variable NO_BRP_STRIP_DEBUG=true when building with debug enabled.
Build root policy modifies the fahctl shebang. On RHEL 8, this results in: + /usr/lib/rpm/redhat/brp-mangle-shebangs mangling shebang in /usr/bin/fahctl from /usr/bin/env python3 to #!/usr/libexec/platform-python Then, rpmbuild adds an automatic requirement dependency on /usr/libexec/platform-python. This package fails to install on recent Fedora versions because platform-python no longer exists: Failed to resolve the transaction: Problem: conflicting requests - nothing provides /usr/libexec/platform-python needed by fah-client-8.5.4-1.x86_64 from @commandline You can try to add to command line: --setopt=optional_metadata_types=filelists to load additional filelists metadata --skip-broken to skip uninstallable packages Let's keep the shebang untouched, which will result in a dependency on /usr/bin/env. Define __brp_mangle_shebangs as %{nil} instead of undefining it, as recommended by: https://bugzilla.redhat.com/show_bug.cgi?id=1597664#c5
Member
|
This is version dependent. Accepting this PR would break builds for other systems. It would have to be wrapped in an |
jcoffland
force-pushed
the
master
branch
3 times, most recently
from
f416e1d to
cc4316d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://v8.github.io/api/head/classv8_1_1String.html#a1520592ac160f6c5e79ace641e09c124