Repository navigation
fix: unify pause naming, add RBAC, typed errors in learn-token and credential-nft (#550-#553) - #677
Merged
DeFiVC merged 4 commits intoOct 21, 2026
Conversation
TheHalalHunter
force-pushed
the
fix/issues-550-551-552-553
branch
from
October 21, 2026 02:43
4338f02 to
d956036
Compare
|
@TheHalalHunter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four related issues in a single PR to keep the contract API changes atomic and reviewable together.
#550 — Unify pause function naming
#551 — Add RBAC to credential-nft and progress-tracker
evoke_role, \has_role\ public functions
#552 — Typed ContractError returns in learn-token
equire_not_paused\ (replaced by \ensure_not_paused\ returning \Result)
#553 — Typed ContractError returns in credential-nft
Testing
All string-message #[should_panic]\ tests have been converted to typed error assertions. Cargo is not installed in the development environment — please run \cargo test --workspace\ as part of CI review.
Commits
Closes #550, Closes #551, Closes #552, Closes #553