Skip to content

test(progress): cover progress_delegated and delegation_revoked event… - #686

Closed
Mainnet-ops wants to merge 1 commit into
ChainLearnOfficial:mainfrom
open-source-from-mainnet:test/progress-delegation-event-emission
Closed

Mainnet-ops wants to merge 1 commit into
ChainLearnOfficial:mainfrom
open-source-from-mainnet:test/progress-delegation-event-emission

Conversation

@Mainnet-ops

Copy link
Copy Markdown
Contributor

… emission

Pull Request

Summary

Changes

Closes #593
Closes #592
Closes #591
Closes #590

Testing

  • cargo build --release --target wasm32-unknown-unknown
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo fmt --all -- --check

Security Considerations

  • Authorization is preserved and require_auth() is called before any state read/write on every state-changing entrypoint
  • Role-based access control (Admin/Minter/Pauser) is enforced and revocation takes effect immediately
  • Initialization/re-initialization guards are intact (rejects double-initialization)
  • Arithmetic uses checked or saturating operations; supply and reward bounds hold
  • Cross-contract calls remain read-only and resolve the progress-tracker address once per batch
  • Storage layout changes are documented with a migration/upgrade plan (see docs/upgrade-guide.md)
  • Transfer restrictions and soulbound credential rules are unchanged
  • All state-changing operations emit appropriate events
  • No hardcoded addresses or private keys; no unsafe; #[no_std] preserved
  • New/changed public functions have doc comments and test coverage for error conditions

Breaking Changes

None

Checklist

  • One focused change; no unrelated formatting, generated files, secrets, or deployment keys
  • Branch is created from the current main
  • Documentation and CHANGELOG.md updated (including a Breaking Changes entry when applicable)
  • Required local checks above pass with no failures
  • Linked issue(s) referenced in the Summary
  • All testable acceptance criteria in the linked issue(s) are met

… emission

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@drips-wave

drips-wave Bot commented Oct 21, 2026

Copy link
Copy Markdown

@Mainnet-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@DeFiVC DeFiVC closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants