[Telemetry] Replace yargs with parseArgs and simplify E2E tests

- Replace yargs with node:util parseArgs in watchdog/main.ts
- Simplify telemetry E2E tests to only test SIGKILL and SIGTERM
- Remove redundant fixture-based tests (exit-0, exit-1, crash)
- Remove fs.watch for cross-platform reliability
- Delete unused server-fixture.ts

Author: ergunsh

src/telemetry/watchdog/main.ts

@@ -4,54 +4,58 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-
 import process from 'node:process';
 import readline from 'node:readline';
-
-import yargs from 'yargs';
-import {hideBin} from 'yargs/helpers';
+import {parseArgs} from 'node:util';
 
 import {logger, saveLogsToFileSync} from '../../logger.js';
-import type { OsType} from '../types.js';
+import type {OsType} from '../types.js';
 import {IpcMessageType} from '../types.js';
 
 import {ClearcutSender} from './clearcut-sender.js';
 
-async function main() {
-  const argv = await yargs(hideBin(process.argv))
-    .option('parent-pid', {
-      type: 'number',
-      demandOption: true,
-      describe: 'PID of the main process to monitor',
-    })
-    .option('app-version', {
-      type: 'string',
-      demandOption: true,
-      describe: 'Application version string',
-    })
-    .option('os-type', {
-      type: 'number',
-      demandOption: true,
-      describe: 'Integer specific to OsType',
-    })
-    .option('log-file', {
-      type: 'string',
-      describe: 'Optional path to log file',
-    })
-    .parse();
+function main() {
+  const {values} = parseArgs({
+    options: {
+      'parent-pid': {type: 'string'},
+      'app-version': {type: 'string'},
+      'os-type': {type: 'string'},
+      'log-file': {type: 'string'},
+    },
+    strict: true,
+  });
+
+  const parentPid = parseInt(values['parent-pid'] ?? '', 10);
+  const appVersion = values['app-version'];
+  const osType = parseInt(values['os-type'] ?? '', 10);
+  const logFile = values['log-file'];
+  if (logFile) {
+    saveLogsToFileSync(logFile);
+  }
 
-  if (argv.logFile) {
-    saveLogsToFileSync(argv.logFile);
+  if (isNaN(parentPid) || !appVersion || isNaN(osType)) {
+    logger(
+      'Invalid arguments provided for watchdog process: ',
+      JSON.stringify({parentPid, appVersion, osType}),
+    );
+    process.exit(1);
   }
 
-  logger('Watchdog started', JSON.stringify({
-    pid: process.pid,
-    parentPid: argv.parentPid,
-    version: argv.appVersion,
-    osType: argv.osType,
-  }, null, 2));
+  logger(
+    'Watchdog started',
+    JSON.stringify(
+      {
+        pid: process.pid,
+        parentPid,
+        version: appVersion,
+        osType,
+      },
+      null,
+      2,
+    ),
+  );
 
-  const sender = new ClearcutSender(argv.appVersion, argv.osType as OsType);
+  const sender = new ClearcutSender(appVersion, osType as OsType);
 
   let isShuttingDown = false;
   function onParentDeath(reason: string) {
@@ -67,7 +71,7 @@ async function main() {
         logger('Shutdown event sent. Exiting.');
         process.exit(0);
       })
-      .catch((err) => {
+      .catch(err => {
         logger('Failed to send shutdown event', err);
         process.exit(1);
       });
@@ -82,13 +86,15 @@ async function main() {
     terminal: false,
   });
 
-  rl.on('line', (line) => {
+  rl.on('line', line => {
     try {
-      if (!line.trim()) {return;}
-      
+      if (!line.trim()) {
+        return;
+      }
+
       const msg = JSON.parse(line);
       if (msg.type === IpcMessageType.EVENT && msg.payload) {
-        sender.send(msg.payload).catch((err) => {
+        sender.send(msg.payload).catch(err => {
           logger('Error sending event', err);
         });
       }
@@ -98,7 +104,9 @@ async function main() {
   });
 }
 
-main().catch((err) => {
+try {
+  main();
+} catch (err) {
   console.error('Watchdog fatal error:', err);
   process.exit(1);
-});
+}