Skip to content

Commit fe51fa1

Browse files
committed
test: fix tests
1 parent a088363 commit fe51fa1

1 file changed

Lines changed: 6 additions & 35 deletions

File tree

tests/PageCollector.test.ts

Lines changed: 6 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -329,40 +329,13 @@ describe('ConsoleCollector', () => {
329329
sinon.restore();
330330
});
331331

332-
it('emits issues on page', async () => {
333-
const browser = getMockBrowser();
334-
const page = (await browser.pages())[0];
335-
// @ts-expect-error internal API.
336-
const cdpSession = page._client();
337-
const onIssuesListener = sinon.spy();
338-
339-
page.on('issue', onIssuesListener);
340-
341-
const collector = new ConsoleCollector(browser, collect => {
342-
return {
343-
devtoolsAggregateddevtoolsAggregatedIssue: issue => {
344-
collect(issue as DevTools.AggregatedIssue);
345-
},
346-
} as ListenerMap;
347-
});
348-
await collector.init([page]);
349-
cdpSession.emit('Audits.issueAdded', {issue});
350-
sinon.assert.calledOnce(onIssuesListener);
351-
352-
const issueArgument = onIssuesListener.getCall(0).args[0];
353-
assert(issueArgument instanceof DevTools.AggregatedIssue);
354-
});
355-
356332
it('collects issues', async () => {
357333
const browser = getMockBrowser();
358334
const page = (await browser.pages())[0];
359-
// @ts-expect-error internal API.
360-
const cdpSession = page._client();
361-
362335
const collector = new ConsoleCollector(browser, collect => {
363336
return {
364337
devtoolsAggregatedIssue: issue => {
365-
collect(issue as DevTools.AggregatedIssue);
338+
collect(issue);
366339
},
367340
} as ListenerMap;
368341
});
@@ -379,29 +352,27 @@ describe('ConsoleCollector', () => {
379352
},
380353
} satisfies Protocol.Audits.InspectorIssue;
381354

382-
cdpSession.emit('Audits.issueAdded', {issue});
383-
cdpSession.emit('Audits.issueAdded', {devtoolsAggregatedIssue: issue2});
355+
page.emit('issue', issue);
356+
page.emit('issue', issue2);
384357
const data = collector.getData(page);
385358
assert.equal(data.length, 2);
386359
});
387360

388361
it('filters duplicated issues', async () => {
389362
const browser = getMockBrowser();
390363
const page = (await browser.pages())[0];
391-
// @ts-expect-error internal API.
392-
const cdpSession = page._client();
393364

394365
const collector = new ConsoleCollector(browser, collect => {
395366
return {
396367
devtoolsAggregatedIssue: issue => {
397-
collect(issue as DevTools.AggregatedIssue);
368+
collect(issue);
398369
},
399370
} as ListenerMap;
400371
});
401372
await collector.init([page]);
402373

403-
cdpSession.emit('Audits.issueAdded', {issue});
404-
cdpSession.emit('Audits.issueAdded', {issue});
374+
page.emit('issue', issue);
375+
page.emit('issue', issue);
405376
const data = collector.getData(page);
406377
assert.equal(data.length, 1);
407378
const collectedIssue = data[0];

0 commit comments

Comments
 (0)