Skip to content

fix: list_pages should work after selected page is closed #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zyzyzyryxy merged 3 commits into from
Mar 30, 2026
+19 −21
Merged

fix: list_pages should work after selected page is closed #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f947ba
fix: list_pages should work after selected page is closed
atian8179 Mar 8, 2026
5a3e0f7
test: add coverage for list_pages after selected page is closed
atian8179 Mar 10, 2026
cd94135
Fix linting issues
Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/pages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
timeoutSchema,
} from './ToolDefinition.js';

export const listPages = definePageTool(args => {
export const listPages = defineTool(args => {
return {
name: 'list_pages',
description: `Get a list of pages ${args?.categoryExtensions ? 'including extension service workers' : ''} open in the browser.`,
Expand Down
38 changes: 18 additions & 20 deletions tests/tools/pages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,21 @@ describe('pages', () => {
describe('list_pages', () => {
it('list pages', async () => {
await withMcpContext(async (response, context) => {
await listPages().handler(
{params: {}, page: context.getSelectedMcpPage()},
response,
context,
);
await listPages().handler({params: {}}, response, context);
assert.ok(response.includePages);
});
});
it('list pages after selected page is closed', async () => {
await withMcpContext(async (response, context) => {
// Create a second page and select it.
const page2 = await context.newPage();
assert.strictEqual(context.getSelectedMcpPage(), page2);

// Close the selected page via puppeteer (simulating external close).
await page2.pptrPage.close();

// list_pages should still work even though the selected page is gone.
await listPages().handler({params: {}}, response, context);
assert.ok(response.includePages);
});
});
Expand All @@ -70,11 +80,7 @@ describe('pages', () => {
const listPageDef = listPages({
categoryExtensions: true,
} as ParsedArguments);
await listPageDef.handler(
{params: {}, page: context.getSelectedMcpPage()},
response,
context,
);
await listPageDef.handler({params: {}}, response, context);

const result = await response.handle(listPageDef.name, context);
const textContent = result.content.find(c => c.type === 'text') as {
Expand Down Expand Up @@ -116,11 +122,7 @@ describe('pages', () => {
const listPageDef = listPages({
categoryExtensions,
} as ParsedArguments);
await listPageDef.handler(
{params: {}, page: context.getSelectedMcpPage()},
response,
context,
);
await listPageDef.handler({params: {}}, response, context);

const result = await response.handle(listPageDef.name, context);
const textContent = result.content.find(c => c.type === 'text') as {
Expand Down Expand Up @@ -177,11 +179,7 @@ describe('pages', () => {
const listPageDef = listPages({
categoryExtensions: true,
} as ParsedArguments);
await listPageDef.handler(
{params: {}, page: context.getSelectedMcpPage()},
response,
context,
);
await listPageDef.handler({params: {}}, response, context);

const result = await response.handle(listPageDef.name, context);
const textContent = result.content.find(c => c.type === 'text') as {
Expand Down