fix: improve connection reliability with retry logic and stale target handling#1177
Closed
znetstar wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
fix: improve connection reliability with retry logic and stale target handling#1177znetstar wants to merge 1 commit intoChromeDevTools:mainfrom
znetstar wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
… handling Add resilience to browser connection and page enumeration: - Retry puppeteer.connect with exponential backoff on transient failures - Extract readDevToolsActivePort helper with I/O retry (fail fast on validation errors) - Clear stale browser reference before reconnecting - Dispose previous McpContext before creating a new one - Wrap browser.pages() in try/catch with a single retry for stale targets - Guard detectOpenDevToolsWindows() so failures don't break tool calls - Catch per-page hasDevTools()/openDevTools() errors individually Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
puppeteer.connectwith exponential backoff on transient failures, clearing stale browser references before reconnectingreadDevToolsActivePorthelper with I/O-only retry (validation errors fail immediately instead of waiting 5s)browser.pages()with a single retry + 100ms delay to handle stale CDP targets (Target.attachToTargeterrors)detectOpenDevToolsWindows()in the tool handler so transient failures don't break tool callsMcpContextbefore creating a new one to prevent resource leaksTest plan
list_pagesvia MCP after Chrome restarts — should return page list instead ofProtocol error (Target.attachToTarget)🤖 Generated with Claude Code