Skip to content

feat: --diff support for take_snapshot#1206

Closed
natorion wants to merge 6 commits intomainfrom
feat/snapshot-diffs
Closed

feat: --diff support for take_snapshot#1206
natorion wants to merge 6 commits intomainfrom
feat/snapshot-diffs

Conversation

@natorion
Copy link
Copy Markdown
Contributor

  • test: ensure snapshot files are copied to build directory
  • feat: add session-based snapshot diffing to take_snapshot (--diff)
  • fix: update CLI to use generated definitions and bundle dependencies for distribution
  • docs: update skills with snapshot diff information

Comment thread package.json
"format": "eslint --cache --fix . && prettier --write --cache .",
"check-format": "eslint --cache . && prettier --check --cache .;",
"gen": "npm run build && npm run docs:generate && npm run cli:generate && npm run format",
"gen": "npm run bundle && npm run docs:generate && npm run cli:generate && npm run format",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert

Comment thread scripts/post-build.ts

// Create i18n mock
const i18nDir = path.join(BUILD_DIR, devtoolsFrontEndCorePath, 'i18n');
fs.mkdirSync(i18nDir, {recursive: true});
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert?

Comment thread scripts/post-build.ts
copySnapshotFiles();
}

function copySnapshotFiles() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert?

Copy link
Copy Markdown
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous diff exploration #815 Do you want to land this @natorion? can we iterate on it or close?

@natorion
Copy link
Copy Markdown
Contributor Author

natorion commented Apr 1, 2026

Previous diff exploration #815 Do you want to land this @natorion? can we iterate on it or close?

Ha no, I don't want to land my PR. This was purely uploaded so I have the CL somewhere stored and can share it with a few folks. Closing!

@natorion natorion closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants