feat: add Edge browser support#1229
Closed
david-risney wants to merge 6 commits intoChromeDevTools:mainfrom
Closed
feat: add Edge browser support#1229david-risney wants to merge 6 commits intoChromeDevTools:mainfrom
david-risney wants to merge 6 commits intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f127f0a to
31e8537
Compare
Contributor
|
Hi David,
I will close this PR for cleanup purposes for now to hash out this initial open questions on the respective issue. |
Author
|
Thanks! I've opened an issue like you suggested: #1235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MCP is wonderful and we field many requests for how to use it with Edge, so I'd love to add the
--browseroption to make it easy to do that.This PR adds support for Microsoft Edge via a new
--browseroption. Chrome remains the default. Edge executable and user data directory resolution is handled for all channels (stable, beta, dev, canary) on Windows, macOS, and Linux. This option will not attempt to download and install Edge - Edge must already be installed on the machine.Example:
Changes
--browser=chrome|edgeCLI optionedgePaths.ts: resolves Edge executable and user data directory per-channel and per-platformbrowser.ts: handle launch and auto-connect scenarios via resolving to Edge executable and user data dir and new URL helper functions to recognizeedge://andedge-extension://schemesMcpContext.ts/McpResponse.ts: use isExtensionUrl() to handle bothchrome-extension://andedge-extension://README.md: "Additional browser support" section documenting Edge usage--browser=option