fix: skip frozen page targets when page enumeration times out#1231
Closed
barretlee wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
fix: skip frozen page targets when page enumeration times out#1231barretlee wants to merge 1 commit intoChromeDevTools:mainfrom
barretlee wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
9e31b48 to
e573157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes page enumeration resilient to frozen/discarded background tabs.
When
browser.pages()fails because Puppeteer times out while initializing a page session (for example onNetwork.enable), MCP now falls back to enumerating page targets one by one and skips only the targets that hit the same recoverable timeout.Motivation
Closes #1230.
In a long-lived Chrome profile, some background tabs can become frozen or discarded by Chrome memory-saving behavior. Before this change, a single bad target could make page enumeration fail for the entire MCP session.
Changes
browser.pages()path for healthy browsersVerification
npm run typechecknpm test -- tests/McpContext.test.tsNetwork.enablestill timed out for affected targetsMcpContext.from()succeeded and skipped the frozen targets