Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/McpResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ export class McpResponse implements Response {
}

attachNetworkRequest(
reqid: number,
reqId: number,
options?: {requestFilePath?: string; responseFilePath?: string},
): void {
this.#attachedNetworkRequestId = reqid;
this.#attachedNetworkRequestId = reqId;
this.#attachedNetworkRequestOptions = options;
}

Expand Down Expand Up @@ -346,7 +346,7 @@ export class McpResponse implements Response {
});
if (!formatter.isValid()) {
throw new Error(
"Can't provide detals for the msgid " + consoleMessageStableId,
"Can't provide details for the msgid " + consoleMessageStableId,
);
}
detailedConsoleMessage = formatter;
Expand Down
8 changes: 4 additions & 4 deletions src/PageCollector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,13 @@ class PageEventSubscriber {
if (this.#issueAggregator) {
this.#issueAggregator.removeEventListener(
DevTools.IssueAggregatorEvents.AGGREGATED_ISSUE_UPDATED,
this.#onAggregatedissue,
this.#onAggregatedIssue,
);
}
this.#issueAggregator = new DevTools.IssueAggregator(this.#issueManager);
this.#issueAggregator.addEventListener(
DevTools.IssueAggregatorEvents.AGGREGATED_ISSUE_UPDATED,
this.#onAggregatedissue,
this.#onAggregatedIssue,
);
}

Expand All @@ -303,15 +303,15 @@ class PageEventSubscriber {
if (this.#issueAggregator) {
this.#issueAggregator.removeEventListener(
DevTools.IssueAggregatorEvents.AGGREGATED_ISSUE_UPDATED,
this.#onAggregatedissue,
this.#onAggregatedIssue,
);
}
void this.#session.send('Audits.disable').catch(() => {
// might fail.
});
}

#onAggregatedissue = (
#onAggregatedIssue = (
event: DevTools.Common.EventTarget.EventTargetEvent<DevTools.AggregatedIssue>,
) => {
if (this.#seenIssues.has(event.data)) {
Expand Down
Loading