chore: add function to sanitize params for tool calls#1250
Merged
Conversation
Collaborator
|
@yulunz can you resolve all format checks? |
yulunz
force-pushed
the
chore/filter-sensitive-args
branch
3 times, most recently
from
5ec0844 to
cc1e822
Compare
yulunz
force-pushed
the
chore/filter-sensitive-args
branch
from
cc1e822 to
dadd005
Compare
Collaborator
Author
hi, of course, should have marked this as a draft. I was thinking like in the CL world :) |
OrKoN
pushed a commit
to mvanhorn/chrome-devtools-mcp
that referenced
this pull request
Apr 1, 2026
…#1250) This adds functions to sanitize the tool call parameters. They are not called as of now since we don't have server side changes landed yet to support these.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…#1257) This adds a script that generates a json file that summarizes all tool calls and arguments for each. - The arguments run through the blocklist filtering so arguments containing high entropy ids are filtered out (e.g. "uid", "msgid" etc). - It uses existing functions from clearcut logger module to transform the arg name and value (i.e. take the length of the string, take the size of the array, and rename the string to be "string_length", and array "array_count" etc). - These functions from the clearcut logger module will be later used to sanitize the params as we start to log them. This doesn't include the append only / deprecation logic just yet (i.e. it's doesn't handle the case when new tools are added / removed, or arguments of the existing tools are modified). This will be added in following PRs. The parent PR is #1250.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functions to sanitize the tool call parameters. They are not called as of now since we don't have server side changes landed yet to support these.