-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore: add a script to generate tool_call_metrics.json for telemetry. #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2026 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import * as fs from 'node:fs'; | ||
| import * as path from 'node:path'; | ||
|
|
||
| import type {ParsedArguments} from '../build/src/bin/chrome-devtools-mcp-cli-options.js'; | ||
| import {generateToolMetrics} from '../build/src/telemetry/toolMetricsUtils.js'; | ||
| import type {ToolDefinition} from '../build/src/tools/ToolDefinition.js'; | ||
| import {createTools} from '../build/src/tools/tools.js'; | ||
|
|
||
| export function HaveUniqueNames(tools: ToolDefinition[]): boolean { | ||
| const toolNames = tools.map(tool => tool.name); | ||
| const toolNamesSet = new Set(toolNames); | ||
| return toolNamesSet.size === toolNames.length; | ||
| } | ||
|
|
||
| function writeToolCallMetricsConfig() { | ||
| const outputPath = path.resolve('src/telemetry/tool_call_metrics.json'); | ||
|
|
||
| const dir = path.dirname(outputPath); | ||
| if (!fs.existsSync(dir)) { | ||
| throw new Error(`Error: Directory ${dir} does not exist.`); | ||
| } | ||
|
|
||
| const fullTools = createTools({slim: false} as ParsedArguments); | ||
| const slimTools = createTools({slim: true} as ParsedArguments); | ||
|
|
||
| const allTools = [...fullTools, ...slimTools]; | ||
|
|
||
| if (!HaveUniqueNames(allTools)) { | ||
| throw new Error('Error: Duplicate tool names found.'); | ||
| } | ||
|
|
||
| // Map tools to their metadata | ||
| const toolData = generateToolMetrics(allTools); | ||
|
|
||
| // Sort by name for determinism | ||
| toolData.sort((a, b) => a.name.localeCompare(b.name)); | ||
|
|
||
| fs.writeFileSync(outputPath, JSON.stringify(toolData, null, 2) + '\n'); | ||
|
|
||
| console.log( | ||
| `Successfully wrote ${toolData.length} tool names with arguments to ${outputPath}`, | ||
| ); | ||
| } | ||
|
|
||
| writeToolCallMetricsConfig(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2026 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import type {ToolDefinition} from '../tools/ToolDefinition.js'; | ||
|
|
||
| import { | ||
| transformArgName, | ||
| transformArgType, | ||
| getZodType, | ||
| PARAM_BLOCKLIST, | ||
| } from './ClearcutLogger.js'; | ||
|
|
||
| /** | ||
| * Validates that all values in an enum are of the homogeneous primitive type. | ||
| * Returns the primitive type string. Throws an error if heterogeneous. | ||
| */ | ||
| export function validateEnumHomogeneity(values: unknown[]): string { | ||
| const firstType = typeof values[0]; | ||
| for (const val of values) { | ||
| if (typeof val !== firstType) { | ||
| throw new Error('Heterogeneous enum types found'); | ||
| } | ||
| } | ||
| return firstType; | ||
| } | ||
|
|
||
| export interface ArgMetric { | ||
| name: string; | ||
| argType: string; | ||
| } | ||
|
|
||
| export interface ToolMetric { | ||
| name: string; | ||
| args: ArgMetric[]; | ||
| } | ||
|
|
||
| /** | ||
| * Generates tool metrics from tool definitions. | ||
| */ | ||
| export function generateToolMetrics(tools: ToolDefinition[]): ToolMetric[] { | ||
| return tools.map(tool => { | ||
| const args: ArgMetric[] = []; | ||
|
|
||
| for (const [name, schema] of Object.entries(tool.schema)) { | ||
| if (PARAM_BLOCKLIST.has(name)) { | ||
| continue; | ||
| } | ||
| const zodType = getZodType(schema); | ||
| const transformedName = transformArgName(zodType, name); | ||
| let argType = transformArgType(zodType); | ||
|
|
||
| if (zodType === 'ZodEnum' && schema._def.values?.length > 0) { | ||
| argType = validateEnumHomogeneity(schema._def.values); | ||
| } | ||
|
|
||
| args.push({ | ||
| name: transformedName, | ||
| argType, | ||
| }); | ||
| } | ||
|
|
||
| return { | ||
| name: tool.name, | ||
| args, | ||
| }; | ||
| }); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.