-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: Add pagination list_network_requests #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OrKoN
merged 9 commits into
ChromeDevTools:main
from
OzTamir:feat/list_network_requests_pagination
Sep 25, 2025
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5be157e
feat: add pagination to `list_network_requests`
OzTamir 953fe35
docs: generate docs
OzTamir 3814022
Merge remote-tracking branch 'upstream/main' into feat/list_network_r…
OzTamir 9ce7636
fix: don't sanitize pagination options
OzTamir 6925f5a
feat: create a generic pagination utility
OzTamir d870210
fix: align test output with McpResponse
OzTamir 522374e
fix: code formatting
OzTamir aa22258
feat: use pageIdx as token
OzTamir 3d0117a
fix: code formatting
OzTamir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| export type PaginationOptions = { | ||
| pageSize?: number; | ||
| pageToken?: string; | ||
| }; | ||
|
|
||
| export type PaginationResult<TItem> = { | ||
| items: readonly TItem[]; | ||
| nextPageToken?: string; | ||
| previousPageToken?: string; | ||
| startIndex: number; | ||
| endIndex: number; | ||
| invalidToken: boolean; | ||
| }; | ||
|
|
||
| const DEFAULT_PAGE_SIZE = 20; | ||
|
|
||
| export function paginate<TItem>( | ||
| items: readonly TItem[], | ||
| options?: PaginationOptions, | ||
| ): PaginationResult<TItem> { | ||
| const total = items.length; | ||
|
|
||
| if (!options || noPaginationOptions(options)) { | ||
| return { | ||
| items, | ||
| nextPageToken: undefined, | ||
| previousPageToken: undefined, | ||
| startIndex: 0, | ||
| endIndex: total, | ||
| invalidToken: false, | ||
| }; | ||
| } | ||
|
|
||
| const pageSize = options.pageSize ?? DEFAULT_PAGE_SIZE; | ||
| const {startIndex, invalidToken} = resolveStartIndex( | ||
| options.pageToken, | ||
| total, | ||
| ); | ||
|
|
||
| const pageItems = items.slice(startIndex, startIndex + pageSize); | ||
| const endIndex = startIndex + pageItems.length; | ||
|
|
||
| const nextPageToken = endIndex < total ? String(endIndex) : undefined; | ||
| const previousPageToken = | ||
| startIndex > 0 ? String(Math.max(startIndex - pageSize, 0)) : undefined; | ||
|
|
||
| return { | ||
| items: pageItems, | ||
| nextPageToken, | ||
| previousPageToken, | ||
| startIndex, | ||
| endIndex, | ||
| invalidToken, | ||
| }; | ||
| } | ||
|
|
||
| function noPaginationOptions(options: PaginationOptions): boolean { | ||
| return ( | ||
| options.pageSize === undefined && | ||
| (options.pageToken === undefined || options.pageToken === null) | ||
| ); | ||
| } | ||
|
|
||
| function resolveStartIndex( | ||
| pageToken: string | undefined, | ||
| total: number, | ||
| ): { | ||
| startIndex: number; | ||
| invalidToken: boolean; | ||
| } { | ||
| if (pageToken === undefined || pageToken === null) { | ||
| return {startIndex: 0, invalidToken: false}; | ||
| } | ||
|
|
||
| const parsed = Number.parseInt(pageToken, 10); | ||
| if (Number.isNaN(parsed) || parsed < 0 || parsed >= total) { | ||
| return {startIndex: 0, invalidToken: true}; | ||
| } | ||
|
|
||
| return {startIndex: parsed, invalidToken: false}; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.