chore: Make in-page tools work with pageId routing#1781
Merged
Conversation
wolfib
changed the title
🤖 I have created a release *beep* *boop* --- ## [0.21.0](chrome-devtools-mcp-v0.20.3...chrome-devtools-mcp-v0.21.0) (2026-04-01) ### 🎉 Features * add a skill for detecting memory leaks using take_memory_snapshot tool ([#1162](#1162)) ([d19a235](d19a235)) ### 🛠️ Fixes * **cli:** avoid defaulting to isolated when userDataDir is provided ([#1258](#1258)) ([73e1e24](73e1e24)) * list_pages should work after selected page is closed ([#1145](#1145)) ([2664455](2664455)) * mark lighthouse and memory as non-read-only ([#1769](#1769)) ([bec9dae](bec9dae)) * **telemetry:** record client name ([9a47b65](9a47b65)) * versioning for Claude Code plugin ([#1233](#1233)) ([966b86f](966b86f)) * wrap .mcp.json config in mcpServers key ([#1246](#1246)) ([c7948cf](c7948cf)) ### 📄 Documentation * Command Code CLI instructions for MCP server ([0a7c0a7](0a7c0a7)) * provide disclaimer about supported browsers ([#1237](#1237)) ([8676b72](8676b72)) ### 🏗️ Refactor * set process titles for easier debugging ([#1770](#1770)) ([0fe3896](0fe3896)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Alex Rudenko <alexrudenko@chromium.org>
Splits out from #1244 per review feedback. 'waitForEventsAfterAction' previously lived in 'McpContext' and always used the selected page's CPU/network throttling settings. With pageId routing, a tool can target a different page than the selected one, meaning wrong throttling multipliers were applied. Moving the method to 'McpPage' fixes this: each tool now calls 'page.waitForEventsAfterAction(...)' and gets the correct page's emulation settings. 'getNetworkMultiplierFromString' is extracted to 'WaitForHelper.ts' to avoid a circular import (McpContext → McpPage already exists). Unblocks #1777.
OrKoN
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the stored
ToolGroupfromMcpContexttoMcpPage, where per-page state should be stored in order for pageId-based routing to work correctly.When appending the list of in-page tools to a response, the list now corresponds to the response's
McpPage, and only falls back to the selectedMcpPagefor tools which are not page-specific.