Skip to content

chore: turn arg name into snake case in sanitization #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yulunz merged 1 commit into from
Apr 15, 2026
Merged

chore: turn arg name into snake case in sanitization #1862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/telemetry/ClearcutLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,16 @@ export function getZodType(zodType: zod.ZodTypeAny): ZodType {
type LoggedToolCallArgValue = string | number | boolean;

export function transformArgName(zodType: ZodType, name: string): string {
const snakeCaseName = name.replace(
/[A-Z]/g,
letter => `_${letter.toLowerCase()}`,
);
if (zodType === 'ZodString') {
return `${name}_length`;
return `${snakeCaseName}_length`;
} else if (zodType === 'ZodArray') {
return `${name}_count`;
return `${snakeCaseName}_count`;
} else {
return name;
return snakeCaseName;
}
}

Expand Down
90 changes: 45 additions & 45 deletions src/telemetry/tool_call_metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"name": "click",
"args": [
{
"name": "dblClick",
"name": "dbl_click",
"argType": "boolean"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand All @@ -24,11 +24,11 @@
"argType": "number"
},
{
"name": "dblClick",
"name": "dbl_click",
"argType": "boolean"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand All @@ -37,7 +37,7 @@
"name": "close_page",
"args": [
{
"name": "pageId",
"name": "page_id",
"argType": "number"
}
]
Expand All @@ -54,7 +54,7 @@
"argType": "number"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand All @@ -63,23 +63,23 @@
"name": "emulate",
"args": [
{
"name": "networkConditions",
"name": "network_conditions",
"argType": "string"
},
{
"name": "cpuThrottlingRate",
"name": "cpu_throttling_rate",
"argType": "number"
},
{
"name": "geolocation_length",
"argType": "number"
},
{
"name": "userAgent_length",
"name": "user_agent_length",
"argType": "number"
},
{
"name": "colorScheme",
"name": "color_scheme",
"argType": "string"
},
{
Expand Down Expand Up @@ -114,7 +114,7 @@
"name": "execute_in_page_tool",
"args": [
{
"name": "toolName_length",
"name": "tool_name_length",
"argType": "number"
},
{
Expand All @@ -131,7 +131,7 @@
"argType": "number"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand All @@ -144,7 +144,7 @@
"argType": "number"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand All @@ -157,11 +157,11 @@
"name": "get_network_request",
"args": [
{
"name": "requestFilePath_length",
"name": "request_file_path_length",
"argType": "number"
},
{
"name": "responseFilePath_length",
"name": "response_file_path_length",
"argType": "number"
}
]
Expand All @@ -170,7 +170,7 @@
"name": "get_tab_id",
"args": [
{
"name": "pageId",
"name": "page_id",
"argType": "number"
}
]
Expand All @@ -183,7 +183,7 @@
"argType": "string"
},
{
"name": "promptText_length",
"name": "prompt_text_length",
"argType": "number"
}
]
Expand All @@ -192,7 +192,7 @@
"name": "hover",
"args": [
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand All @@ -218,7 +218,7 @@
"argType": "string"
},
{
"name": "outputDirPath_length",
"name": "output_dir_path_length",
"argType": "number"
}
]
Expand All @@ -227,19 +227,19 @@
"name": "list_console_messages",
"args": [
{
"name": "pageSize",
"name": "page_size",
"argType": "number"
},
{
"name": "pageIdx",
"name": "page_idx",
"argType": "number"
},
{
"name": "types_count",
"argType": "number"
},
{
"name": "includePreservedMessages",
"name": "include_preserved_messages",
"argType": "boolean"
}
]
Expand All @@ -256,19 +256,19 @@
"name": "list_network_requests",
"args": [
{
"name": "pageSize",
"name": "page_size",
"argType": "number"
},
{
"name": "pageIdx",
"name": "page_idx",
"argType": "number"
},
{
"name": "resourceTypes_count",
"name": "resource_types_count",
"argType": "number"
},
{
"name": "includePreservedRequests",
"name": "include_preserved_requests",
"argType": "boolean"
}
]
Expand Down Expand Up @@ -298,15 +298,15 @@
"argType": "number"
},
{
"name": "ignoreCache",
"name": "ignore_cache",
"argType": "boolean"
},
{
"name": "handleBeforeUnload",
"name": "handle_before_unload",
"argType": "string"
},
{
"name": "initScript_length",
"name": "init_script_length",
"argType": "number"
},
{
Expand All @@ -327,7 +327,7 @@
"argType": "boolean"
},
{
"name": "isolatedContext_length",
"name": "isolated_context_length",
"argType": "number"
},
{
Expand All @@ -340,11 +340,11 @@
"name": "performance_analyze_insight",
"args": [
{
"name": "insightSetId_length",
"name": "insight_set_id_length",
"argType": "number"
},
{
"name": "insightName_length",
"name": "insight_name_length",
"argType": "number"
}
]
Expand All @@ -357,11 +357,11 @@
"argType": "boolean"
},
{
"name": "autoStop",
"name": "auto_stop",
"argType": "boolean"
},
{
"name": "filePath_length",
"name": "file_path_length",
"argType": "number"
}
]
Expand All @@ -370,7 +370,7 @@
"name": "performance_stop_trace",
"args": [
{
"name": "filePath_length",
"name": "file_path_length",
"argType": "number"
}
]
Expand All @@ -383,7 +383,7 @@
"argType": "number"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand Down Expand Up @@ -431,11 +431,11 @@
"name": "select_page",
"args": [
{
"name": "pageId",
"name": "page_id",
"argType": "number"
},
{
"name": "bringToFront",
"name": "bring_to_front",
"argType": "boolean"
}
]
Expand All @@ -444,7 +444,7 @@
"name": "take_memory_snapshot",
"args": [
{
"name": "filePath_length",
"name": "file_path_length",
"argType": "number"
}
]
Expand All @@ -461,11 +461,11 @@
"argType": "number"
},
{
"name": "fullPage",
"name": "full_page",
"argType": "boolean"
},
{
"name": "filePath_length",
"name": "file_path_length",
"argType": "number"
}
]
Expand All @@ -478,7 +478,7 @@
"argType": "boolean"
},
{
"name": "filePath_length",
"name": "file_path_length",
"argType": "number"
}
]
Expand All @@ -500,7 +500,7 @@
"argType": "number"
},
{
"name": "submitKey_length",
"name": "submit_key_length",
"argType": "number"
}
]
Expand All @@ -518,11 +518,11 @@
"name": "upload_file",
"args": [
{
"name": "filePath_length",
"name": "file_path_length",
"argType": "number"
},
{
"name": "includeSnapshot",
"name": "include_snapshot",
"argType": "boolean"
}
]
Expand Down
10 changes: 5 additions & 5 deletions tests/telemetry/ClearcutLogger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,11 @@ describe('ClearcutLogger', () => {
const sanitized = sanitizeParams(params, schema);

assert.deepStrictEqual(sanitized, {
myString_length: 5,
myArray_count: 2,
myNumber: 42,
myBool: true,
myEnum: 'a',
my_string_length: 5,
my_array_count: 2,
my_number: 42,
my_bool: true,
my_enum: 'a',
});
});

Expand Down
4 changes: 2 additions & 2 deletions tests/telemetry/toolMetricsUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('toolMetricsUtils', () => {
assert.strictEqual(metrics.length, 1);
assert.strictEqual(metrics[0].name, 'test_tool');
assert.strictEqual(metrics[0].args.length, 1); // uid is blocked
assert.strictEqual(metrics[0].args[0].name, 'argStr_length');
assert.strictEqual(metrics[0].args[0].name, 'arg_str_length');
assert.strictEqual(metrics[0].args[0].argType, 'number');
});

Expand All @@ -77,7 +77,7 @@ describe('toolMetricsUtils', () => {

const metrics = generateToolMetrics([mockTool]);
assert.strictEqual(metrics.length, 1);
assert.strictEqual(metrics[0].args[0].name, 'argEnum');
assert.strictEqual(metrics[0].args[0].name, 'arg_enum');
assert.strictEqual(metrics[0].args[0].argType, 'string');
});
});
Expand Down
Loading