Merged
Conversation
Collaborator
Author
|
TODO for myself: verify log entries show up on the server side. |
OrKoN
approved these changes
Apr 15, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
This fixes the casing of the tool call params. We don't need any server side fix since they are already converted to snake case in the proto definition. This is needed nevertheless since the sanitizeParams() function will be called when we log the params (see the next PR: #1863 1863).
yulunz
force-pushed
the
feat/log-tool-call-params
branch
from
6aec4d0 to
03b7e20
Compare
yulunz
force-pushed
the
feat/log-tool-call-params
branch
from
03b7e20 to
ba1a7d0
Compare
Collaborator
Author
|
verified tool params are being logged correctly (and anonymously :) ) |
beaufortfrancois
pushed a commit
to beaufortfrancois/chrome-devtools-mcp
that referenced
this pull request
Apr 16, 2026
…1862) This fixes the casing of the tool call params. We don't need any server side fix since they are already converted to snake case in the proto definition. This is needed nevertheless since the sanitizeParams() function will be called when we log the params (see the next PR: ChromeDevTools#1863 1863).
beaufortfrancois
pushed a commit
to beaufortfrancois/chrome-devtools-mcp
that referenced
this pull request
Apr 16, 2026
This will enable logging for tool params. The server side changes should all be ready now. parent pr: ChromeDevTools#1862
wolfib
pushed a commit
that referenced
this pull request
Apr 16, 2026
This fixes the casing of the tool call params. We don't need any server side fix since they are already converted to snake case in the proto definition. This is needed nevertheless since the sanitizeParams() function will be called when we log the params (see the next PR: #1863 1863).
wolfib
pushed a commit
that referenced
this pull request
Apr 16, 2026
This will enable logging for tool params. The server side changes should all be ready now. parent pr: #1862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable logging for tool params. The server side changes should all be ready now.
parent pr: #1862
BEGIN_COMMIT_OVERRIDE
chore: add tool call params logging
END_COMMIT_OVERRIDE