Skip to content

test: save WebP responses with the right extension#1901

Merged
OrKoN merged 1 commit intoChromeDevTools:mainfrom
MukundaKatta:codex/chrome-webp-mime-fix
Apr 20, 2026
Merged

test: save WebP responses with the right extension#1901
OrKoN merged 1 commit intoChromeDevTools:mainfrom
MukundaKatta:codex/chrome-webp-mime-fix

Conversation

@MukundaKatta
Copy link
Copy Markdown
Contributor

Summary

  • fix the WebP MIME type match in daemon response handling
  • save responses with a suffix instead of falling back to
  • add a regression test for WebP image handling

Testing

  • npm run build
  • node --test --test-name-pattern="parsing" build/tests/daemon/client.test.js

Fixes #1898

@OrKoN OrKoN force-pushed the codex/chrome-webp-mime-fix branch from f98aa2e to 7be1a39 Compare April 20, 2026 11:39
@OrKoN OrKoN force-pushed the codex/chrome-webp-mime-fix branch from 7be1a39 to dbdee8b Compare April 20, 2026 11:57
@OrKoN OrKoN changed the title fix: save WebP responses with the right extension test: save WebP responses with the right extension Apr 20, 2026
Copy link
Copy Markdown
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@OrKoN OrKoN enabled auto-merge April 20, 2026 11:57
@OrKoN OrKoN added this pull request to the merge queue Apr 20, 2026
Merged via the queue into ChromeDevTools:main with commit 3a24d71 Apr 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: WebP image MIME type check uses 'webp' instead of 'image/webp' in handleResponse

2 participants