chore: update CLI generator to generate all possible tools#1962
Open
chore: update CLI generator to generate all possible tools#1962
Conversation
OrKoN
reviewed
Apr 27, 2026
OrKoN
reviewed
Apr 27, 2026
OrKoN
reviewed
Apr 27, 2026
OrKoN
reviewed
Apr 27, 2026
OrKoN
reviewed
Apr 27, 2026
nroscino
force-pushed
the
feat/update-cli
branch
from
6bce414 to
91d70d6
Compare
nroscino
force-pushed
the
feat/update-cli
branch
from
91d70d6 to
e347b85
Compare
OrKoN
reviewed
Apr 28, 2026
nroscino
force-pushed
the
feat/update-cli
branch
from
da2e9e7 to
7dfba95
Compare
OrKoN
reviewed
Apr 28, 2026
Collaborator
|
The tests seem to fail still. |
OrKoN
reviewed
Apr 29, 2026
Comment on lines
-64
to
-69
| if (!('default' in cliOptions.headless)) { | ||
| throw new Error('headless cli option unexpectedly does not have a default'); | ||
| } | ||
| if ('default' in cliOptions.isolated) { | ||
| throw new Error('isolated cli option unexpectedly has a default'); | ||
| } |
Collaborator
There was a problem hiding this comment.
what was the reason to remove these lines?
OrKoN
reviewed
Apr 29, 2026
| delete startCliOptions.categoryNetwork; | ||
| delete startCliOptions.categoryExtensions; | ||
| // Always on in CLI. | ||
| delete startCliOptions.experimentalStructuredContent; |
OrKoN
reviewed
Apr 29, 2026
| delete startCliOptions.viewport; | ||
| // CLI is generated based on the default tool definitions. To enable conditional | ||
| // tools, they need to be enabled during CLI generation. | ||
| delete startCliOptions.experimentalPageIdRouting; |
Collaborator
There was a problem hiding this comment.
I think we should keep this one.
OrKoN
reviewed
Apr 29, 2026
| delete startCliOptions.experimentalPageIdRouting; | ||
| delete startCliOptions.experimentalVision; | ||
| delete startCliOptions.experimentalWebmcp; | ||
| delete startCliOptions.experimentalInteropTools; |
OrKoN
reviewed
Apr 29, 2026
Comment on lines
+37
to
+43
| export const CONDITION_TO_FLAG: Record<string, string> = { | ||
| computerVision: 'experimentalVision', | ||
| experimentalMemory: 'experimentalMemory', | ||
| experimentalInteropTools: 'experimentalInteropTools', | ||
| screencast: 'experimentalScreencast', | ||
| experimentalWebmcp: 'experimentalWebmcp', | ||
| }; |
Collaborator
There was a problem hiding this comment.
could we instead have a convention that a condition has to match the flag name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds all tools in the CLI interface. When a tool is not enabled the server responds with an error guiding the user on how to enable the category or the experiment.