Skip to content

chore(memory): sort all by retainer size#1963

Merged
Lightning00Blade merged 1 commit intomainfrom
sort-nodes
Apr 28, 2026
Merged

chore(memory): sort all by retainer size#1963
Lightning00Blade merged 1 commit intomainfrom
sort-nodes

Conversation

@Lightning00Blade
Copy link
Copy Markdown
Collaborator

@Lightning00Blade Lightning00Blade commented Apr 27, 2026

This is a better measurement as if object self size is X and the retainerSize Y. X will always be smaller then Y, there Y will be the actual size on the Heap.

@Lightning00Blade Lightning00Blade changed the title chore(memory): sort nodes by size chore(memory): sort all by retainer size Apr 27, 2026
@Lightning00Blade Lightning00Blade requested a review from OrKoN April 27, 2026 20:23
Comment thread tests/third_party_notices.test.js.snapshot
Comment thread src/formatters/HeapSnapshotFormatter.ts
@Lightning00Blade Lightning00Blade added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 66dacb8 Apr 28, 2026
31 of 33 checks passed
@Lightning00Blade Lightning00Blade deleted the sort-nodes branch April 28, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants