(do not merge): exposing additional performance functions#266
Closed
jackfranklin wants to merge 2 commits intomainfrom
Closed
(do not merge): exposing additional performance functions#266jackfranklin wants to merge 2 commits intomainfrom
jackfranklin wants to merge 2 commits intomainfrom
Conversation
This PR is so we have a branch that has the bigger set of performance functions available to it that are equivalent to the ones the DevTools Performance Agent has. If we decide we want to expose these functions, we will do so via reusing the implementation from upstream, not via the copy/paste of this PR, but this is the quickest way to get them available to test.
Collaborator
|
Closing as not planning to land soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is so we have a branch that has the bigger set of performance
functions available to it that are equivalent to the ones the DevTools
Performance Agent has.
If we decide we want to expose these functions, we will do so via
reusing the implementation from upstream, not via the copy/paste of this
PR, but this is the quickest way to get them available to test.