feat: Improve test coverage#276
Closed
RodrigoAngelCollazo wants to merge 1 commit intoChromeDevTools:mainfrom
RodrigoAngelCollazo:improve-test-coverage
Closed
feat: Improve test coverage#276RodrigoAngelCollazo wants to merge 1 commit intoChromeDevTools:mainfrom RodrigoAngelCollazo:improve-test-coverage
RodrigoAngelCollazo wants to merge 1 commit intoChromeDevTools:mainfrom
RodrigoAngelCollazo:improve-test-coverage
Conversation
This commit improves the test coverage of the repository by adding new tests for the `Mutex` class and fixing a failing test. The following changes are included: - **`tests/Mutex.test.ts`**: Added a new test file for the `Mutex` class, which previously had no test coverage. The new tests cover acquiring and releasing locks, ensuring exclusive access, and handling concurrent requests. - **`package.json`**: - Added a `test:coverage` script to enable test coverage reporting. - Added a `clean` script to the `build` process to prevent issues with stale test files. - **`tests/tools/screenshot.test.ts`**: Fixed a failing test that was caused by a page being too large for Puppeteer to handle. Reduced the page size to a level that Puppeteer can manage while still triggering the intended file-saving logic. Added a comment to explain the change.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the test coverage of the repository by adding new tests for the
Mutexclass and fixing a failing test.The following changes are included:
tests/Mutex.test.ts: Added a new test file for theMutexclass, which previously had no test coverage. The new tests cover acquiring and releasing locks, ensuring exclusive access, and handling concurrent requests.package.json:test:coveragescript to enable test coverage reporting.cleanscript to thebuildprocess to prevent issues with stale test files.tests/tools/screenshot.test.ts: Fixed a failing test that was caused by a page being too large for Puppeteer to handle. Reduced the page size to a level that Puppeteer can manage while still triggering the intended file-saving logic. Added a comment to explain the change.