feat: Add Node.js v21 version check#278
Closed
RodrigoAngelCollazo wants to merge 1 commit intoChromeDevTools:mainfrom
RodrigoAngelCollazo:fix-node-version-check
Closed
feat: Add Node.js v21 version check#278RodrigoAngelCollazo wants to merge 1 commit intoChromeDevTools:mainfrom RodrigoAngelCollazo:fix-node-version-check
RodrigoAngelCollazo wants to merge 1 commit intoChromeDevTools:mainfrom
RodrigoAngelCollazo:fix-node-version-check
Conversation
The entrypoint script `src/index.ts` was missing a check for Node.js version 21. Although the `package.json` `engines` field specifies supported versions, this check provides a more user-friendly error message. This change adds a condition to exit with an error if the major version of Node.js is 21, consistent with other version checks in the file. A new test file, `tests/version.test.ts`, is added to verify this behavior in isolation, ensuring that the script exits as expected when an unsupported version is used.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entrypoint script
src/index.tswas missing a check for Node.js version 21. Although thepackage.jsonenginesfield specifies supported versions, this check provides a more user-friendly error message.This change adds a condition to exit with an error if the major version of Node.js is 21, consistent with other version checks in the file.
A new test file,
tests/version.test.ts, is added to verify this behavior in isolation, ensuring that the script exits as expected when an unsupported version is used.