feat: add WebSocket endpoint and custom headers support#398
Closed
daohoangson wants to merge 2 commits intoChromeDevTools:mainfrom
Closed
feat: add WebSocket endpoint and custom headers support#398daohoangson wants to merge 2 commits intoChromeDevTools:mainfrom
daohoangson wants to merge 2 commits intoChromeDevTools:mainfrom
Conversation
Add support for connecting to Chrome via WebSocket endpoint with custom headers: - Add --browserWsEndpoint/-w argument for direct WebSocket connections - Add --wsHeaders argument for custom WebSocket headers (e.g., auth tokens) - Update ensureBrowserConnected to support both browserURL and browserWSEndpoint - Add validation for WebSocket protocol (ws:// or wss://) - Add JSON validation for custom headers - Update documentation with usage examples This enables authenticated remote debugging scenarios and provides an alternative to the HTTP-based --browserUrl connection method. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for connecting to Chrome via WebSocket endpoint with custom headers, enabling authenticated remote debugging scenarios and providing an alternative to the HTTP-based connection method.
What's New
This PR introduces two new CLI arguments:
--browserWsEndpoint/-w: Connect directly to Chrome using a WebSocket URLws://127.0.0.1:9222/devtools/browser/<id>--browserUrl(mutually exclusive)--wsHeaders: Pass custom headers for WebSocket connections (JSON format)'{"Authorization":"Bearer token"}'--browserWsEndpointUse Cases