perf: improve options for sharing content#426
Closed
ArcherGu wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
perf: improve options for sharing content#426ArcherGu wants to merge 1 commit intoChromeDevTools:mainfrom
ArcherGu wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
OrKoN
requested changes
Oct 20, 2025
Collaborator
OrKoN
left a comment
OrKoN
left a comment
There was a problem hiding this comment.
Thanks for the PR. Refactoring makes sense but we do not plan to make the snapshot configurable on each tool call right now. We might re-consider this later but for now could you please separate refactoring from adding new tool definitions.
Author
I'm not quite sure what you mean? Should I close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should probably extract the option parameters for content that can be shared by multiple tools