test: add test coverage for Mutex, DevToolsConnectionAdapter, and WaitForHelper#499
Closed
RodrigoAngelCollazo wants to merge 2 commits intoChromeDevTools:mainfrom
RodrigoAngelCollazo:add-test-coverage
Closed
test: add test coverage for Mutex, DevToolsConnectionAdapter, and WaitForHelper#499RodrigoAngelCollazo wants to merge 2 commits intoChromeDevTools:mainfrom RodrigoAngelCollazo:add-test-coverage
RodrigoAngelCollazo wants to merge 2 commits intoChromeDevTools:mainfrom
RodrigoAngelCollazo:add-test-coverage
Conversation
…tForHelper Adds unit tests for the following previously untested files: - `src/Mutex.ts` - `src/DevToolsConnectionAdapter.ts` - `src/WaitForHelper.ts` The new tests follow the existing testing conventions of the repository, using `node:test`, `node:assert`, and `sinon` for mocking. These tests improve the overall test coverage of the project and ensure the correctness of these components.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
OrKoN
changed the title
Collaborator
|
Thanks for the PR! Could you please revert changes to package-lock and sign the CLA according to the bot instructions? |
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tForHelper
Adds unit tests for the following previously untested files:
src/Mutex.tssrc/DevToolsConnectionAdapter.tssrc/WaitForHelper.tsThe new tests follow the existing testing conventions of the repository, using
node:test,node:assert, andsinonfor mocking. These tests improve the overall test coverage of the project and ensure the correctness of these components.