Skip to content

chore: split withBrowser into withBrowser and withMcpContext #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szuend merged 1 commit into from
Nov 28, 2025
Merged

chore: split withBrowser into withBrowser and withMcpContext #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/McpContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ import sinon from 'sinon';

import type {TraceResult} from '../src/trace-processing/parse.js';

import {html, withBrowser} from './utils.js';
import {html, withMcpContext} from './utils.js';

describe('McpContext', () => {
it('list pages', async () => {
await withBrowser(async (_response, context) => {
await withMcpContext(async (_response, context) => {
const page = context.getSelectedPage();
await page.setContent(
html`<button>Click me</button
Expand All @@ -40,7 +40,7 @@ describe('McpContext', () => {
});

it('can store and retrieve performance traces', async () => {
await withBrowser(async (_response, context) => {
await withMcpContext(async (_response, context) => {
const fakeTrace1 = {} as unknown as TraceResult;
const fakeTrace2 = {} as unknown as TraceResult;
context.storeTraceRecording(fakeTrace1);
Expand All @@ -50,7 +50,7 @@ describe('McpContext', () => {
});

it('should update default timeout when cpu throttling changes', async () => {
await withBrowser(async (_response, context) => {
await withMcpContext(async (_response, context) => {
const page = await context.newPage();
const timeoutBefore = page.getDefaultTimeout();
context.setCpuThrottlingRate(2);
Expand All @@ -60,7 +60,7 @@ describe('McpContext', () => {
});

it('should update default timeout when network conditions changes', async () => {
await withBrowser(async (_response, context) => {
await withMcpContext(async (_response, context) => {
const page = await context.newPage();
const timeoutBefore = page.getDefaultNavigationTimeout();
context.setNetworkConditions('Slow 3G');
Expand All @@ -70,7 +70,7 @@ describe('McpContext', () => {
});

it('should call waitForEventsAfterAction with correct multipliers', async () => {
await withBrowser(async (_response, context) => {
await withMcpContext(async (_response, context) => {
const page = await context.newPage();

context.setCpuThrottlingRate(2);
Expand All @@ -86,7 +86,7 @@ describe('McpContext', () => {
});

it('should should detect open DevTools pages', async () => {
await withBrowser(
await withMcpContext(
async (_response, context) => {
const page = await context.newPage();
// TODO: we do not know when the CLI flag to auto open DevTools will run
Expand Down
64 changes: 32 additions & 32 deletions tests/McpResponse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ import {
getMockResponse,
html,
stabilizeResponseOutput,
withBrowser,
withMcpContext,
} from './utils.js';

describe('McpResponse', () => {
it('list pages', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludePages(true);
const result = await response.handle('test', context);
assert.equal(result[0].type, 'text');
Expand All @@ -30,7 +30,7 @@ describe('McpResponse', () => {
});

it('allows response text lines to be added', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.appendResponseLine('Testing 1');
response.appendResponseLine('Testing 2');
const result = await response.handle('test', context);
Expand All @@ -40,7 +40,7 @@ describe('McpResponse', () => {
});

it('does not include anything in response if snapshot is null', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
page.accessibility.snapshot = async () => null;
const result = await response.handle('test', context);
Expand All @@ -50,7 +50,7 @@ describe('McpResponse', () => {
});

it('returns correctly formatted snapshot for a simple tree', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
await page.setContent(
html`<button>Click me</button
Expand All @@ -68,7 +68,7 @@ describe('McpResponse', () => {
});

it('returns values for textboxes', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
await page.setContent(
html`<label
Expand All @@ -86,7 +86,7 @@ describe('McpResponse', () => {
});

it('returns verbose snapshot', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
await page.setContent(html`<aside>test</aside>`);
response.includeSnapshot({
Expand All @@ -101,7 +101,7 @@ describe('McpResponse', () => {
it('saves snapshot to file', async t => {
const filePath = join(tmpdir(), 'test-screenshot.png');
try {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
await page.setContent(html`<aside>test</aside>`);
response.includeSnapshot({
Expand All @@ -120,7 +120,7 @@ describe('McpResponse', () => {
});

it('adds throttling setting when it is not null', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
context.setNetworkConditions('Slow 3G');
const result = await response.handle('test', context);
assert.equal(result[0].type, 'text');
Expand All @@ -129,15 +129,15 @@ describe('McpResponse', () => {
});

it('does not include throttling setting when it is null', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const result = await response.handle('test', context);
context.setNetworkConditions(null);
assert.equal(result[0].type, 'text');
assert.strictEqual(result[0].text, `# test response`);
});
});
it('adds image when image is attached', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.attachImage({data: 'imageBase64', mimeType: 'image/png'});
const result = await response.handle('test', context);
assert.strictEqual(result[0].text, `# test response`);
Expand All @@ -148,23 +148,23 @@ describe('McpResponse', () => {
});

it('adds cpu throttling setting when it is over 1', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
context.setCpuThrottlingRate(4);
const result = await response.handle('test', context);
t.assert.snapshot?.(result[0].text);
});
});

it('does not include cpu throttling setting when it is 1', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
context.setCpuThrottlingRate(1);
const result = await response.handle('test', context);
assert.strictEqual(result[0].text, `# test response`);
});
});

it('adds a prompt dialog', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
const dialogPromise = new Promise<void>(resolve => {
page.on('dialog', () => {
Expand All @@ -182,7 +182,7 @@ describe('McpResponse', () => {
});

it('adds an alert dialog', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const page = context.getSelectedPage();
const dialogPromise = new Promise<void>(resolve => {
page.on('dialog', () => {
Expand All @@ -200,7 +200,7 @@ describe('McpResponse', () => {
});

it('add network requests when setting is true', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true);
context.getNetworkRequests = () => {
return [getMockRequest({stableId: 1}), getMockRequest({stableId: 2})];
Expand All @@ -211,7 +211,7 @@ describe('McpResponse', () => {
});

it('does not include network requests when setting is false', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(false);
context.getNetworkRequests = () => {
return [getMockRequest()];
Expand All @@ -222,7 +222,7 @@ describe('McpResponse', () => {
});

it('add network request when attached with POST data', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true);
const httpResponse = getMockResponse();
httpResponse.buffer = () => {
Expand Down Expand Up @@ -254,7 +254,7 @@ describe('McpResponse', () => {
});

it('add network request when attached', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true);
const request = getMockRequest();
context.getNetworkRequests = () => {
Expand All @@ -270,7 +270,7 @@ describe('McpResponse', () => {
});

it('adds console messages when the setting is true', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeConsoleData(true);
const page = context.getSelectedPage();
const consoleMessagePromise = new Promise<void>(resolve => {
Expand All @@ -289,7 +289,7 @@ describe('McpResponse', () => {
});

it('adds a message when no console messages exist', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeConsoleData(true);
const result = await response.handle('test', context);
assert.ok(result[0].text);
Expand All @@ -298,7 +298,7 @@ describe('McpResponse', () => {
});

it("doesn't list the issue message if mapping returns null", async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const mockAggregatedIssue = getMockAggregatedIssue();
const mockDescription = {
file: 'not-existing-description-file.md',
Expand All @@ -317,7 +317,7 @@ describe('McpResponse', () => {
});

it('throws error if mapping returns null on get issue details', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const mockAggregatedIssue = getMockAggregatedIssue();
const mockDescription = {
file: 'not-existing-description-file.md',
Expand All @@ -340,7 +340,7 @@ describe('McpResponse', () => {

describe('McpResponse network request filtering', () => {
it('filters network requests by resource type', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true, {
resourceTypes: ['script', 'stylesheet'],
});
Expand All @@ -358,7 +358,7 @@ describe('McpResponse network request filtering', () => {
});

it('filters network requests by single resource type', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true, {
resourceTypes: ['image'],
});
Expand All @@ -375,7 +375,7 @@ describe('McpResponse network request filtering', () => {
});

it('shows no requests when filter matches nothing', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true, {
resourceTypes: ['font'],
});
Expand All @@ -392,7 +392,7 @@ describe('McpResponse network request filtering', () => {
});

it('shows all requests when no filters are provided', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true);
context.getNetworkRequests = () => {
return [
Expand All @@ -410,7 +410,7 @@ describe('McpResponse network request filtering', () => {
});

it('shows all requests when empty resourceTypes array is provided', async t => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
response.setIncludeNetworkRequests(true, {
resourceTypes: [],
});
Expand All @@ -431,7 +431,7 @@ describe('McpResponse network request filtering', () => {

describe('McpResponse network pagination', () => {
it('returns all requests when pagination is not provided', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const requests = Array.from({length: 5}, () => getMockRequest());
context.getNetworkRequests = () => requests;
response.setIncludeNetworkRequests(true);
Expand All @@ -444,7 +444,7 @@ describe('McpResponse network pagination', () => {
});

it('returns first page by default', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const requests = Array.from({length: 30}, (_, idx) =>
getMockRequest({method: `GET-${idx}`}),
);
Expand All @@ -461,7 +461,7 @@ describe('McpResponse network pagination', () => {
});

it('returns subsequent page when pageIdx provided', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const requests = Array.from({length: 25}, (_, idx) =>
getMockRequest({method: `GET-${idx}`}),
);
Expand All @@ -479,7 +479,7 @@ describe('McpResponse network pagination', () => {
});

it('handles invalid page number by showing first page', async () => {
await withBrowser(async (response, context) => {
await withMcpContext(async (response, context) => {
const requests = Array.from({length: 5}, () => getMockRequest());
context.getNetworkRequests = () => requests;
response.setIncludeNetworkRequests(true, {
Expand Down
Loading