fix: use page.setViewport instead of page.resize#650
Closed
yasirusman85 wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
fix: use page.setViewport instead of page.resize#650yasirusman85 wants to merge 1 commit intoChromeDevTools:mainfrom
yasirusman85 wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
Collaborator
|
Thanks for the PR. We are not using set viewport because of the issues with visual rendering that can arise when the window size does not match the viewport. We will keep using the resize for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #645.
The
resize_pagetool was failing with aProtocol error (Browser.setContentsSize): 'Browser.setContentsSize' wasn't foundwhen running against certain Chrome environments (e.g., remote debugging). This was because it relied on an internalpage.resizemethod that usesBrowser.setContentsSize, which is not universally supported.This PR replaces the internal
page.resizecall with the standard Puppeteerpage.setViewportmethod. This usesEmulation.setDeviceMetricsOverrideunder the hood, which is the standard and supported way to resize the viewport for testing and emulation.Changes
page.resizewithpage.setViewportin src/tools/pages.ts.Verification
resize_pagenow correctly callspage.setViewportwith the provided dimensions.