Skip to content

feat(tool-page): support visit pages with header#712

Closed
clChenLiang wants to merge 2 commits intoChromeDevTools:mainfrom
clChenLiang:feat/setheaders-in-tools
Closed

feat(tool-page): support visit pages with header#712
clChenLiang wants to merge 2 commits intoChromeDevTools:mainfrom
clChenLiang:feat/setheaders-in-tools

Conversation

@clChenLiang
Copy link
Copy Markdown

support to visit some page with special headers

Comment thread src/tools/pages.ts
headers: zod
.record(zod.string())
.optional()
.describe('Optional headers to send with the navigation request.'),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the headers would be sent for all requests on the page until the headers are removed so this description is not correct. Could you clarify what use case you have? Would #692 work better for the use case? cc @natorion @Lightning00Blade

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always have an application, which will be test in a prod env.
this test condition, need to divide different with really prod env which user use.
the best way, is to use a special headers

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the #692 send with header in the whole mcp lives.
may be in this, can be more flexible

@OrKoN
Copy link
Copy Markdown
Collaborator

OrKoN commented Feb 18, 2026

Closing as stale. The current implementation in this PR leaks headers beyond individual navigations. The ideal solution would be to either have a separate parameter in emulate tool or remove extra headers after the navigation is done.

@OrKoN OrKoN closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants