Skip to content

test: fix flaky network test by normalizing accept-language header #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ergunsh merged 1 commit into from
Jan 8, 2026
Merged

test: fix flaky network test by normalizing accept-language header #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/tools/network.test.js.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ exports[`network > network_get_request > should get request from previous naviga
## Request http://localhost:<port>/one
Status: [success - 200]
### Request Headers
- accept-language:en-US,en;q=0.9
- accept-language:<lang>
- upgrade-insecure-requests:1
- user-agent:<user-agent>
- sec-ch-ua:"Chromium";v="<version>", "Not A(Brand";v="24"
Expand Down
4 changes: 4 additions & 0 deletions tests/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,10 @@ export function stabilizeResponseOutput(text: unknown) {

const savedSnapshot = /Saved snapshot to (.*)/g;
output = output.replaceAll(savedSnapshot, 'Saved snapshot to <file>');

const acceptLanguageRegEx = /accept-language:.*\n/g;
output = output.replaceAll(acceptLanguageRegEx, 'accept-language:<lang>\n');

return output;
}

Expand Down