Skip to content

chore: rename PageIssueSubscriber to PageEventSubscriber #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szuend merged 1 commit into from
Feb 3, 2026
Merged

chore: rename PageIssueSubscriber to PageEventSubscriber #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/PageCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,12 @@ export class PageCollector<T> {
export class ConsoleCollector extends PageCollector<
ConsoleMessage | Error | DevTools.AggregatedIssue
> {
#subscribedPages = new WeakMap<Page, PageIssueSubscriber>();
#subscribedPages = new WeakMap<Page, PageEventSubscriber>();

override addPage(page: Page): void {
super.addPage(page);
if (!this.#subscribedPages.has(page)) {
const subscriber = new PageIssueSubscriber(page);
const subscriber = new PageEventSubscriber(page);
this.#subscribedPages.set(page, subscriber);
void subscriber.subscribe();
}
Expand All @@ -250,7 +250,7 @@ export class ConsoleCollector extends PageCollector<
}
}

class PageIssueSubscriber {
class PageEventSubscriber {
#issueManager = new FakeIssuesManager();
#issueAggregator = new DevTools.IssueAggregator(this.#issueManager);
#seenKeys = new Set<string>();
Expand Down