Conversation
Contributor
Author
|
@OrKoN: Two things I find awkward in this CL: 1) We have to pass the |
Collaborator
|
Can we have a SymbolizedStackTrace class and re-use it in both? |
OrKoN
approved these changes
Feb 5, 2026
Contributor
Author
Not sure I follow, what would be the difference to |
Collaborator
|
It would be an API that we can take right into Puppeteer :) |
wolfib
pushed a commit
to wolfib/chrome-devtools-mcp
that referenced
this pull request
Mar 10, 2026
The "SymbolizedError" class represents a fully resolved error: The stack trace is fully resolved and (in the future), the full `Error.cause` chain is also fully resolved. We'll use the `SymbolizedError` for both "uncaught exceptions" as well as when logging `Error` objects to the console (e.g. `console.log(new Error())`. This means the `resolvedArgs` array in `ConsoleFormatter` will contain one `SymbolizedError` instance for every `Error` object logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "SymbolizedError" class represents a fully resolved error: The stack trace is fully resolved and (in the future), the full
Error.causechain is also fully resolved.We'll use the
SymbolizedErrorfor both "uncaught exceptions" as well as when loggingErrorobjects to the console (e.g.console.log(new Error()). This means theresolvedArgsarray inConsoleFormatterwill contain oneSymbolizedErrorinstance for everyErrorobject logged.