chore: refactor ConsoleFormatter construction#896
Merged
Conversation
wolfib
pushed a commit
to wolfib/chrome-devtools-mcp
that referenced
this pull request
Mar 10, 2026
This PR shuffles code around in `ConsoleFormatter` so the data flow is more clear and flexible. Instead of augmenting an existing instance via `#loadDetailedData` we pass the detailed data (if needed) via constructor. The overall public API stays exactly the same, only the internal implementation changed. This also makes it trivial to inject "resolved arguments for testing", which we'll need to test `SymbolizedError` instances as part of `resolvedArgs`. Drive-by: Make options and message ID mandatory. All call-sites already passed these so its a no-op to tighten the type here and we can simplify toString() a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shuffles code around in
ConsoleFormatterso the data flow is more clear and flexible. Instead of augmenting an existing instance via#loadDetailedDatawe pass the detailed data (if needed) via constructor. The overall public API stays exactly the same, only the internal implementation changed.This also makes it trivial to inject "resolved arguments for testing", which we'll need to test
SymbolizedErrorinstances as part ofresolvedArgs.Drive-by: Make options and message ID mandatory. All call-sites already passed these so its a no-op to tighten the type here and we can simplify toString() a bit.