fix(input): include page list when click opens new tab#964
Closed
SucRunBug wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
fix(input): include page list when click opens new tab#964SucRunBug wants to merge 1 commit intoChromeDevTools:mainfrom
SucRunBug wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Thanks I think the change makes sense in general. Could you please sign the CLA? |
OrKoN
reviewed
Feb 18, 2026
| }; | ||
| page.on('popup', popupListener); | ||
| try { | ||
| await context.waitForEventsAfterAction(async () => { |
Collaborator
There was a problem hiding this comment.
let's embed it into waitForEventsAfterAction since not only clicks can trigger a popup?
Collaborator
|
Closing as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a UX gap where
click/click_atcan open a new tab but the tool response doesn't include updated page context, making it hard for agents to detect that navigation happened in a new page.Closes #367.
What changed
Updated
/Users/yanmai/Downloads/MCP 测试/chrome-devtools-mcp/src/tools/input.ts:click: listens forpopupduring the action and callsresponse.setIncludePages(true)if a new tab/window is opened.click_at: same behavior asclick.finallyblocks.Updated
/Users/yanmai/Downloads/MCP 测试/chrome-devtools-mcp/tests/tools/input.test.ts:includes pages if click opens a new tabincludes pages if click at coordinates opens a new tabWhy this approach
Validation
npm run typechecknpx eslint src/tools/input.ts tests/tools/input.test.ts