Skip to content

fix: apply pagination to network request output #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AI-Reviewer-QS wants to merge 1 commit into from
Closed

fix: apply pagination to network request output #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 9 additions & 24 deletions src/McpResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,36 +589,21 @@ Call ${handleDialog.name} to handle it before continuing.`);
}

if (this.#networkRequestsOptions?.include) {
let requests = context.getNetworkRequests(
this.#networkRequestsOptions?.includePreservedRequests,
);

// Apply resource type filtering if specified
if (this.#networkRequestsOptions.resourceTypes?.length) {
const normalizedTypes = new Set(
this.#networkRequestsOptions.resourceTypes,
);
requests = requests.filter(request => {
const type = request.resourceType();
return normalizedTypes.has(type);
});
}

response.push('## Network requests');
if (requests.length) {
const networkFormatters = data.networkRequests ?? [];
if (networkFormatters.length) {
const paginationData = this.#dataWithPagination(
requests,
networkFormatters,
this.#networkRequestsOptions.pagination,
);
structuredContent.pagination = paginationData.pagination;
response.push(...paginationData.info);
if (data.networkRequests) {
structuredContent.networkRequests = [];
for (const formatter of data.networkRequests) {
response.push(formatter.toString());
structuredContent.networkRequests.push(formatter.toJSON());
}
}
structuredContent.networkRequests = paginationData.items.map(
formatter => formatter.toJSON(),
);
response.push(
...paginationData.items.map(formatter => formatter.toString()),
);
} else {
response.push('No requests found.');
}
Expand Down
294 changes: 0 additions & 294 deletions tests/McpResponse.test.js.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,27 +483,6 @@ exports[`McpResponse network pagination > handles invalid page number by showing
"invalidPage": true
},
"networkRequests": [
{
"requestId": 1,
"method": "GET",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET",
Expand Down Expand Up @@ -654,146 +633,6 @@ exports[`McpResponse network pagination > returns first page by default 1`] = `
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-10",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-11",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-12",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-13",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-14",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-15",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-16",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-17",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-18",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-19",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-20",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-21",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-22",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-23",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-24",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-25",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-26",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-27",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-28",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-29",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
}
]
}
Expand All @@ -811,76 +650,6 @@ exports[`McpResponse network pagination > returns subsequent page when pageIdx p
"invalidPage": false
},
"networkRequests": [
{
"requestId": 1,
"method": "GET-0",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-1",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-2",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-3",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-4",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-5",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-6",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-7",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-8",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-9",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-10",
Expand Down Expand Up @@ -950,41 +719,6 @@ exports[`McpResponse network pagination > returns subsequent page when pageIdx p
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-20",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-21",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-22",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-23",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
},
{
"requestId": 1,
"method": "GET-24",
"url": "http://example.com",
"status": "[pending]",
"selectedInDevToolsUI": false
}
]
}
Expand Down Expand Up @@ -1445,31 +1179,3 @@ No requests found.
exports[`McpResponse network request filtering > shows no requests when filter matches nothing 2`] = `
{}
`;

exports[`extensions > lists extensions 1`] = `
# test response
## Extensions
id=id1 "Extension 1" v1.0 Enabled
id=id2 "Extension 2" v2.0 Disabled
`;

exports[`extensions > lists extensions 2`] = `
{
"extensions": [
{
"id": "id1",
"name": "Extension 1",
"version": "1.0",
"isEnabled": true,
"path": "/path/to/ext1"
},
{
"id": "id2",
"name": "Extension 2",
"version": "2.0",
"isEnabled": false,
"path": "/path/to/ext2"
}
]
}
`;