Skip to content

fix: validate file paths in saveFile to prevent path traversal #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AI-Reviewer-QS wants to merge 1 commit into from
Closed

fix: validate file paths in saveFile to prevent path traversal #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/McpContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,11 +701,17 @@ export class McpContext implements Context {
): Promise<{filename: string}> {
try {
const filePath = path.resolve(filename);
const cwd = process.cwd();
if (!filePath.startsWith(cwd + path.sep) && filePath !== cwd) {
throw new Error(
`File path must be within the current working directory: ${cwd}`,
);
}
await fs.writeFile(filePath, data);
return {filename};
} catch (err) {
this.logger(err);
throw new Error('Could not save a screenshot to a file', {cause: err});
throw new Error('Could not save a file', {cause: err});
}
}

Expand Down