SSF-205 FM Dashboard Frontend#173
Conversation
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
small little fixes~ great pr!
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
first pass looks good, should hopefully be done after this! ty justinnnn
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
this is awesome! thanks for adding the pagination deeplinking! found a missing portion regarding admin request management, but should be a quick fix~
| setWasDeeplinked(true); | ||
| } | ||
| } else { | ||
| navigate(ROUTES.REQUEST_FORM, { replace: true }); |
There was a problem hiding this comment.
when the deeplinked id doesn't match anything, it does navigates to the pantry route (/request-form), so an admin or volunteer hitting ?requestId=999 (not found) goes to an unrelated page. can we change it to match what the close handler does & just strip the query param
| const RequestManagement: React.FC<RequestManagementProps> = ({ | ||
| fetchRequests: fetchData, | ||
| enableVolunteerActions = true, | ||
| initialRequestId, |
There was a problem hiding this comment.
i noticed admin food request deeplink wasn't working & turns out admin wrapper never passed initialRequestId but volunteer wrapper had it from before this pr.
could you abstract the searchParams into this shared component so neither wrapper needs the prop for the deeplink to work?
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
i know you just implemented it but, based on yurika's point, can we actually not reset the pagination back to 1 on modal closing?
| setErrorMessage('Error fetching upcoming donations.'); | ||
| } | ||
|
|
||
| if (donations.status === 'fulfilled') { |
There was a problem hiding this comment.
why do we need to check for it to be fulfilled? im trying to think about a case where the food manufacturer ships out a donation, and while being shipped (or maybe a volunteer updates the status to fulfilled much later), there is a chance it could be sooner than some of the other fulfilled status orders. lmk your thoughts/if this makes sense.
3 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-205
📝 Description
I simply implemented the food manufacturer dashboard frontend and linking functionality for both upcoming and recent donations.
/fm-dashboard
✔️ Verification
Verified proper functionality and aligned design with figma
🏕️ (Optional) Future Work / Notes
N/A