[SSF-212] Filter for approved pantry & FM Backend#182
Open
jiang-h-y wants to merge 23 commits into
Open
Conversation
…y that is approved
…ons, fixes commit e537533
dburkhart07
requested changes
May 24, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
some very small things, looks great though!
| @InjectRepository(Pantry) private pantryRepo: Repository<Pantry>, | ||
| @InjectRepository(Donation) private donationRepo: Repository<Donation>, | ||
| @InjectRepository(DonationItem) | ||
| private donationItemRepo: Repository<DonationItem>, |
There was a problem hiding this comment.
Can we delete this since it's no longer used?
| ); | ||
| } | ||
|
|
||
| if (pantry.status !== ApplicationStatus.APPROVED) { |
There was a problem hiding this comment.
I don't think we need this one. Technically speaking, assuming we are doing proper checks for creating requests and orders, we should never have an unapproved pantry attached to request
| throw new NotFoundException(`Order ${orderId} not found`); | ||
| } | ||
|
|
||
| if (order.request.pantry.status !== ApplicationStatus.APPROVED) { |
| throw new NotFoundException(`Order ${orderId} not found`); | ||
| } | ||
|
|
||
| if (order.foodManufacturer.status !== ApplicationStatus.APPROVED) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-212
📝 Description
✔️ Verification
🏕️ (Optional) Future Work / Notes
updateFoodManufacturerApplicationinapps/backend/src/foodManufacturers/manufacturers.service.spec.tsBadRequestExceptionorConflictExceptionfor non-approved pantries/FMs based on neighboring code