Repository navigation
feat(frontend): add commitment detail page showing on-chain record, attestations and dispute status - #2119
Merged
1nonlypiece merged 2 commits intoOct 24, 2026
Conversation
…estations and disputes - Add /commitments/[id] route displaying terms, timeline, yield, and compliance - Validate commitment ID as u64 decimal string without invoking RPC on malformed input - Implement Soroban read helpers getCommitment, getAttestations, and getDispute - Render historical attestations sorted newest first with relative and absolute times - Render active dispute section only when contract returns Some - Link on-chain items and activity events from dashboard to /commitments/[id] - Add comprehensive unit and component tests with mocked simulation results Closes Commitlabs-Org#2089
|
@ravimahatonp is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2089 by adding a dedicated, shareable commitment detail page at
/commitments/[id]that directly reads the on-chain record, historical compliance attestations, and active dispute state from the Soroban escrow contract.Closes #2089
Key Changes
src/app/commitments/[id]/page.tsx):idas an unsigned 64-bit integer (u64) without triggering RPC network calls on malformed or out-of-range IDs (abc,-1, > 2^64-1).aria-busy), Not-Found (contractNotFounderror code UI/UX Design: Design and implement the My Commitments page with commitment list, filters, and status indicators #3), and Error fallback with interactive retry.get_disputereturnsSome).src/lib/soroban/read.ts):getCommitment(id),getAttestations(id),getDispute(id).validateCommitmentId(id)andisNotFoundError(err).formatRelativeTime,formatAbsoluteTime) and address abbreviation utilities.src/app/dashboard/page.tsx):/commitments/[id].src/app/globals.css):created,funded,released,refunded,disputed,violated, andcancelled.Testing & Verification
npm test: 27 passing tests acrosssrc/lib/soroban/__tests__/read.test.tsandsrc/app/commitments/[id]/__tests__/page.test.tsx(100% green).npm run typecheck: TypeScript compilation passed with zero errors (tsc --noEmit).npm run circular: Madge circular dependency check passed with zero circularities.npm run build: Production Next.js build created/commitments/[id]route cleanly.npm run size: Passed all route performance and bundle size budget checks (check-bundle-budget.mjs).