Skip to content

feat(frontend): generate typed escrow client bindings and fail CI on … - #2122

Merged
1nonlypiece merged 1 commit into
Commitlabs-Org:masterfrom
probablyABug:feat/2099-escrow-bindings-abi-drift
Oct 24, 2026
Merged

1nonlypiece merged 1 commit into
Commitlabs-Org:masterfrom
probablyABug:feat/2099-escrow-bindings-abi-drift

Conversation

@probablyABug

Copy link
Copy Markdown
Contributor

…ABI drift (#2099)

  • Generate typed client bindings with Stellar CLI in packages/escrow-client
  • Add scripts/gen-escrow-bindings.sh for deterministic contract build and bindings generation
  • Implement getEscrowClient factory wiring Freighter's signTransaction and config in src/lib/soroban/escrow-client.ts
  • Add abi-drift-check job to .github/workflows/contracts.yml running git diff --exit-code and tsc --noEmit
  • Add unit tests for client factory (escrow-client.test.ts) and snapshot pinning UI error codes 1-15 (escrow-errors.test.ts)
  • Configure package.json, tsconfig.json, vitest.config.ts, and next.config.js for escrow-client integration

Closes #2099

Description

Please include a summary of the changes and the related issue. List any dependencies that are required for this change.

Closes # (issue number)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Please review the Developer Guide before checking the items below:

  • My code follows the code style and standards of this project (strict TypeScript, components/functions/constants naming conventions).
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated or added documentation where relevant (DEVELOPER_GUIDE.md, README.md, or inline files).
  • I have added unit/integration tests that prove my fix is effective or that my feature works.
  • Any new or modified logic has at least 95% test coverage (verified via pnpm run test:coverage or npm run test:coverage).
  • I have ran the project linter (pnpm lint or npm run lint) and fixed all error diagnostics.
  • I have verified that this change fits within the 96-hour campaign timeframe for contributor assignments.
  • I have attached screenshots/videos showing the before and after states for any visual or UI changes.

Visual Changes (if applicable)

Please add screenshots, screen recordings, or GIFs showcasing the user interface changes.

Join the Discussion

Need help or want to chat? Join our CommitLabs Discord server.

…ABI drift (Commitlabs-Org#2099)

- Generate typed client bindings with Stellar CLI in packages/escrow-client
- Add scripts/gen-escrow-bindings.sh for deterministic contract build and bindings generation
- Implement getEscrowClient factory wiring Freighter's signTransaction and config in src/lib/soroban/escrow-client.ts
- Add abi-drift-check job to .github/workflows/contracts.yml running git diff --exit-code and tsc --noEmit
- Add unit tests for client factory (escrow-client.test.ts) and snapshot pinning UI error codes 1-15 (escrow-errors.test.ts)
- Configure package.json, tsconfig.json, vitest.config.ts, and next.config.js for escrow-client integration

Closes Commitlabs-Org#2099
@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@Stephan-Thomas is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

@1nonlypiece
1nonlypiece merged commit e28a847 into Commitlabs-Org:master Oct 24, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] Generate typed escrow client bindings from the contract spec and fail CI on ABI drift

3 participants