Skip to content

baton-github: add optinRequired to licence resource type#169

Merged
Bencheng21 merged 1 commit into
mainfrom
ben/optin-in-licence-resource
Jun 1, 2026
Merged

baton-github: add optinRequired to licence resource type#169
Bencheng21 merged 1 commit into
mainfrom
ben/optin-in-licence-resource

Conversation

@Bencheng21

Copy link
Copy Markdown
Contributor

No description provided.

@Bencheng21 Bencheng21 requested a review from a team May 29, 2026 22:56
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: baton-github: add optinRequired to licence resource type

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This PR adds OptInRequired to the license resource type annotations. The previous skipEntitlementsAnnotations("license") helper produced V1Identifier + SkipEntitlements; the new inline annotations.New(...) call preserves both of those and adds OptInRequired. The change is correct, minimal, and introduces no issues.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@Bencheng21 Bencheng21 force-pushed the ben/optin-in-licence-resource branch from c4bfffd to 1cf0c14 Compare May 29, 2026 23:01
@Bencheng21 Bencheng21 requested a review from laurenleach May 29, 2026 23:01

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@Bencheng21 Bencheng21 merged commit cf6f174 into main Jun 1, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants