Skip to content

add skip anomaly detection annotation on invitations#173

Merged
laurenleach merged 1 commit into
mainfrom
lauren/add-skip-anomaly-invitation
Jun 10, 2026
Merged

add skip anomaly detection annotation on invitations#173
laurenleach merged 1 commit into
mainfrom
lauren/add-skip-anomaly-invitation

Conversation

@laurenleach

@laurenleach laurenleach commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

ConductorOne/baton-sdk#926

Sync anomaly detection flags a sync when a resource type's count drops significantly between syncs. For some resource types this drop is legitimate (e.g. invitations that disappear once accepted). This lets a connector mark such a resource type so anomaly detection ignores drops for it only; all other resource types are still checked.

@laurenleach laurenleach requested a review from a team June 10, 2026 00:11
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: add skip anomaly detection annotation on invitations

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This PR adds a SkipSyncAnomalyDetection annotation to the invitation resource type, both in the Go code and baton_capabilities.json. Invitations naturally disappear once accepted, so their count can legitimately drop between syncs — skipping anomaly detection for this type prevents false alarms. The implementation correctly appends the new annotation to the existing V1Identifier annotations. No issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@laurenleach laurenleach merged commit e4ec3f8 into main Jun 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants