fix: mark api-key, password, and scim-client-secret as isSecret in config_schema#46
Merged
Conversation
…nfig_schema The SCIM API key, basic-auth password, and OAuth client secret are credentials but were not flagged secret, so they were stored and surfaced as plain config. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
Contributor
Connector PR Review: test: fix TestServiceProviders inverted arg order and correct provider count to 4Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThe new commit changes only pkg/config/scim_config_test.go, swapping require.Equal(t, len(providers), 5) to require.Equal(t, 4, len(providers)). This fixes both the inverted (expected, actual) argument order and the wrong expected count: there are exactly 4 service provider YAML files (miro, postman, slack, zoom) embedded under pkg/config/service_providers/, so the assertion is now correct. No new issues found. Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
api-key,password, andscim-client-secretas secret (username, client-id, account-id, and config-path fields stay non-secret). baton-scim defines config in Go with no committed config_schema.json; the fix addsfield.WithIsSecret(true).Review only — do not merge.