feat(storage): add GCS parity and public file URI semantics#1509
Open
kkopanidis wants to merge 2 commits into
Open
feat(storage): add GCS parity and public file URI semantics#1509kkopanidis wants to merge 2 commits into
kkopanidis wants to merge 2 commits into
Conversation
Replace the deprecated Google Cloud Storage provider with a full implementation aligned to AWS S3 and Azure, including UBLA-safe IAM public access, v4 signed URLs, ADC/inline JSON auth, and fixes for deleteContainer, deleteFolder, exists, getSignedUrl, and folder markers.
Store stable Conduit-relative URIs for public files so private-container public files resolve through Storage without unsupported long-lived provider signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This expands the original GCS provider rewrite into a broader public-file URL contract for the storage module.
GCS provider parity:
IStorageProvidermethods for containers, folders, files, and signed URLs.existsso it returns the provider result instead of always returningtrue.google.serviceAccountKeyJson), and Application Default Credentials.roles/storage.objectViewerforallUsers) for public buckets.Public file URL semantics:
File.urias a stable Conduit-relative path (/storage/getFileUrl/:id).File.url/sourceUrlas direct provider/CDN URLs only when both the container and file are public.urionly and signing provider URLs on demand through Conduit.isPublicvalues.getPublicUrlhandling.uriand clear stale direct URLs for public files in private containers.Validation
npm run buildinmodules/storagenpm run buildinlibraries/grpc-sdkManual test plan
googlewith a GCS bucket or emulator.sourceUrl,url, anduri.isPublicthrows a clear validation error.urionly; unauthenticatedGET /storage/getFileUrl/:idreturns a fresh signed URL.existsreturningfalsefor missing files.uri, and private-container public files have stale direct URLs cleared.