fix: support multi-arch container image builds (arm64, amd64)#6
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: support multi-arch container image builds (arm64, amd64)#6AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
Replace single-arch amd64-only download with multi-stage build that downloads both amd64 and arm64 binaries, then uses TARGETARCH to copy the correct one into the final image. Fixes ContainerSSH/ContainerSSH#696 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
force-pushed
the
fix/multi-arch-container-image
branch
from
c9c3848 to
16d2629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official containerssh Docker image is published as
linux/amd64only. The Dockerfile hardcodes the_linux_amd64.tar.gzdownload URL, so arm64 users can't use the image.The fix uses the
TARGETARCHbuild arg to download the correct binary for the target architecture, and publishes multi-arch manifests for both amd64 and arm64.Fixes #6