Repository navigation
fix(a11y): restore RouteAnnouncer, add useRouteFocus and route titles - #1419
Merged
Baskarayelu merged 3 commits intoOct 22, 2026
Merged
Conversation
- Re-implement RouteAnnouncer against the full specification in RouteAnnouncer.test.tsx:
- Import labels from src/config/navigation.ts
- Render polite live region with role="status", aria-atomic="true", aria-relevant="additions text"
- Export resolvePageLabel, resolveRouteLabel, clampLabel, buildAnnouncement, ANNOUNCE_DELAY_MS, ANNOUNCEMENT_DELAY_MS, MAX_LABEL_LENGTH, UNKNOWN_ROUTE_LABEL
- Normalize slashes, handle dynamic segment fallbacks, and clear synchronously before delayed update for repeat announcements
- Repair mechanical defects in src/components/RouteAnnouncer.test.tsx (missing imports, array initialEntries, typo to%Be)
- Implement useRouteFocus hook and integrate into Layout:
- Move focus to h1 (with tabIndex={-1}) after ANNOUNCE_DELAY_MS, falling back to #main-content
- Ignore initial load and query-string-only changes (?tab=x)
- Handle lazy routes that suspend via MutationObserver
- Add useDocumentTitle to Home, Attestations, and SignIn so all routes have distinct titles (WCAG 2.4.2)
- Add comprehensive test coverage in useRouteFocus.test.tsx and pageTitles.test.tsx
|
@praizeD10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@Baskarayelu task completed please merge and assign points |
Author
|
@Baskarayelu please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1389