Repository navigation
feat(settings): explain unreadable browser profiles in a dialog - #51
Merged
Merged
Conversation
The "+" menu now shows a short item under a browser whose profiles could not be read, and choosing it shows the explanation in a dialog: the text is too long for a menu item. The macOS menu did not show it at all. On macOS the dialog offers to open the Full Disk Access list in System Settings, and the explanation tells to remove Preferis Settings from the list and add it again after an update. A release without a Developer ID signature is another app to macOS after each update, so the access it was given no longer applies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DetectedBrowserViewModel.Note) in a dialog titled "The browser profiles of {browser} could not be read.". The explanation was too long for a menu item, and the macOS menu did not show it at all.x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles) through the newISettingsPlatform.OpenFullDiskAccessSettings(). Windows shows OK only: its explanation is to start the browser once.Verification
dotnet test test/Preferis.Settings.Core.Tests: 248 passed, including the translation audit (which also reads the AppKit and WinUI pages) and 4 new tests (written first and seen failing).dotnet build src/Preferis.Settings.Windows -p:Platform=x64: 0 warnings, 0 errors.🤖 Generated with Claude Code