Repository navigation
Add configurable stat synchronization - #33
AryanGupta833 wants to merge 2 commits into
Conversation
D3ller
left a comment
D3ller
left a comment
There was a problem hiding this comment.
Hi! Thanks for your contribution and the time you spent working on this PR!
However, this PR goes beyond the scope of issue #23. The issue was only about adding a configuration file and commands to enable or disable synchronization, not implementing the food and potion synchronization systems themselves.
I'd prefer to keep these features in separate PRs so they can be reviewed and tested independently.
Could you please limit this PR to the original issue's scope?
Thanks for understanding!
|
Hi, thanks for the feedback! I'm sorry for taking the PR beyond the scope of issue #23 and creating extra work during the review. I've updated the PR by removing the food and potion synchronization implementations and their registrations, and restored the original behavior in The configuration file, configuration manager, enable/disable commands, and health synchronization toggle remain in place. I've also verified that the updated code passes the build and tests. Sorry again for the oversight, and thank you for your time and guidance. Could you please review the updated changes when you get a chance? |
|
Hi! I've addressed the scope feedback and pushed the cleanup in commit I also noticed that the required “Source branch must be develop” check is failing because this PR currently targets Could you please clarify the expected workflow for contributions from forks? I want to make sure I follow the repository's branching policy without introducing unrelated changes or affecting the shared Thanks! |
|
I'm gonna check this tomorrow. |
D3ller
added
documentation
Add /sharedgroup enable and disable to toggle health synchronization, stored in configuration.yml. Both commands are refused during a game. When health is disabled, damage, regeneration, lethal hits and deaths stay individual: SharedHealthService, the resurrect listener and the death fallback all check the toggle. Co-authored-by: AryanGupta833 <206203305+AryanGupta833@users.noreply.github.com>
|
Merged via #44, thanks! |
2 participants
Summary
Adds configurable synchronization settings for shared health, food, and potion effects.
Changes
configuration.ymlwith health, food, and potion synchronization toggles./sharedgroup enable <health|food|potions>to enable synchronization./sharedgroup disable <health|food|potions>to disable synchronization.Testing
.\gradlew.bat clean test build— passed.Notes
Live Minecraft server behavior has not yet been verified.