fix: Lower log level for KeyError in bulk config get#797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When the admin deletes a config section in ConfigurationManager, it is common for the frontend javascript to then re-request the deleted part of the tree as it re-draws after commit (it's hard to keep track of the full chain of changes in the client code as the admin is free to order them however they want). This doesn't have any negative effects (the rest of the tree is still returned), but results in a full stack trace being logged on the server side: This pull request lowers this to info as it's not an actual problem.
Regards,
Simon
BEGINRELEASENOTES
FIX: Lower log level for KeyError in ConfigManager bulk config get
ENDRELEASENOTES