Skip to content

ci(dsm): make dsm kafka test tolerant of kafka exceptions#18655

Open
robcarlan-datadog wants to merge 5 commits into
mainfrom
rob.carlan/fix-dsm-kafka-test-flakes
Open

ci(dsm): make dsm kafka test tolerant of kafka exceptions#18655
robcarlan-datadog wants to merge 5 commits into
mainfrom
rob.carlan/fix-dsm-kafka-test-flakes

Conversation

@robcarlan-datadog

@robcarlan-datadog robcarlan-datadog commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Addresses some kafka test flake for DSM:

  1. For the kafka_topic fixture, wait for the topic to exist
  2. Makes kafka tests tolerant of ephemeral kafka exceptions such as broker not found
  3. Skip failure for DSM cluster_id - there is some known flakiness here

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64, 1]   View in Datadog   GitLab

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b413640 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jun 17, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-17 19:34:28

Comparing candidate commit 6f4f625 in PR branch rob.carlan/fix-dsm-kafka-test-flakes with baseline commit ce0161c in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 618 metrics, 10 unstable metrics.

scenario:iastaspects-strip_noaspect

  • 🟥 execution_time [+22.607µs; +27.801µs] or [+10.122%; +12.448%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+93.142µs; +103.053µs] or [+21.839%; +24.163%]

scenario:span-start

  • 🟥 execution_time [+1.505ms; +1.651ms] or [+10.031%; +11.003%]

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codeowners resolved as

tests/contrib/kafka/conftest.py                                         @DataDog/python-guild

Removed comments about potential broker propagation delays.
@robcarlan-datadog robcarlan-datadog added changelog/no-changelog A changelog entry is not required for this PR. data stream monitoring labels Jun 18, 2026
@robcarlan-datadog robcarlan-datadog marked this pull request as ready for review June 18, 2026 14:40
@robcarlan-datadog robcarlan-datadog requested review from a team as code owners June 18, 2026 14:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff2bf8e280

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/contrib/kafka/conftest.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. data stream monitoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants